Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

droidcam: init at 1.6 #108346

Merged
merged 1 commit into from Jan 6, 2021
Merged

droidcam: init at 1.6 #108346

merged 1 commit into from Jan 6, 2021

Conversation

suhr
Copy link
Contributor

@suhr suhr commented Jan 3, 2021 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@suhr suhr mentioned this pull request Jan 3, 2021
Closed
@lukegb
Copy link
Contributor

lukegb commented Jan 3, 2021

This doesn't seem to build - https://github.com/NixOS/nixpkgs/pull/108346/checks?check_run_id=1640694049

@suhr
Copy link
Contributor Author

suhr commented Jan 3, 2021

Yes, that's why it's marked as a draft.

@lukegb
Copy link
Contributor

lukegb commented Jan 3, 2021

D'oh, missed that.

@suhr suhr force-pushed the droidcam branch 2 times, most recently from c89026f to adbf8e5 Compare January 4, 2021 11:56
@suhr suhr marked this pull request as ready for review January 4, 2021 11:57
@suhr
Copy link
Contributor Author

suhr commented Jan 4, 2021

Now it compiles and runs.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108346 run on x86_64-linux 1

1 package built:
  • droidcam

@SuperSandro2000 SuperSandro2000 merged commit 842500c into NixOS:master Jan 6, 2021
@suhr suhr deleted the droidcam branch January 6, 2021 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@collares collares collares left review comments

@jtojnar jtojnar jtojnar left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@suhr @lukegb @SuperSandro2000 @collares @jtojnar