Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kdeApplications.kaccounts-integration: unbreak derivation #108345

Merged
merged 1 commit into from Jan 3, 2021
Merged

kdeApplications.kaccounts-integration: unbreak derivation #108345

merged 1 commit into from Jan 3, 2021

Conversation

lukegb
Copy link
Contributor

@lukegb lukegb commented Jan 3, 2021 •
edited

Motivation for this change

Unbreaks evaluation.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lukegb lukegb requested a review from ttuegel as a code owner January 3, 2021 20:22
@lukegb lukegb mentioned this pull request Jan 3, 2021
Merged
10 tasks
@SuperSandro2000 SuperSandro2000 merged commit fe0e26d into NixOS:master Jan 3, 2021
@eliasp
Copy link
Member

eliasp commented Jan 3, 2021

Thank you!

@lukegb lukegb deleted the unbreak-head branch December 5, 2022 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel ttuegel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lukegb @eliasp @SuperSandro2000