@blitz can you take a look at this (and possibly at the virtualbox tests, which don't seem to run for me)

@bryanasdev000

I am not sure how to test directly from nixpkgs (without changing NIX_PATH) however, after the patch and a nix-build -A virtualbox I managed to build and check the graphical interface of virtualbox (result/bin/VirtualBox).

I think this will not use the patched kernel modules. To update your system using a local nixpkgs checkout you can do nixos-rebuild -I nixpkgs=/your/checkout/... boot and then reboot. (This boots your system into nixpkgs unstable, so this might or might not be want you want.)

I tried your branch and can confirm that:

• VirtualBox is starting
• I was able to resume a Windows 10 VM
• I was able to resume an ArchLinux VM

Kernel: Linux nixo-t14s 5.10.4 #1-NixOS SMP Wed Dec 30 10:54:29 UTC 2020 x86_64 GNU/Linux

Thanks for taking this up! If I understand the upstream ticket, correctly the single patch is not sufficient to get full functionality. Fortunately, the changes for 5.10 support have already been added to their subversion repo.

I suggest picking these official patches instead of only the single one from the ticket description:

• https://www.virtualbox.org/changeset/87053/vbox
• https://www.virtualbox.org/changeset/87092/vbox
• https://www.virtualbox.org/changeset/87074/vbox

No problem, after work I will add the other patches and test again.

@bryanasdev000

I am not sure how to test directly from nixpkgs (without changing NIX_PATH) however, after the patch and a nix-build -A virtualbox I managed to build and check the graphical interface of virtualbox (result/bin/VirtualBox).

I think this will not use the patched kernel modules. To update your system using a local nixpkgs checkout you can do nixos-rebuild -I nixpkgs=/your/checkout/... boot and then reboot. (This boots your system into nixpkgs unstable, so this might or might not be want you want.)

No problem, I like living on the edge, I just hope I don't have to compile a lot lol, and yes after some tests I realized that the result is unable to load any driver (even if this version of virtualbox is already in my env.pkgs).

I tried your branch and can confirm that:

• VirtualBox is starting
• I was able to resume a Windows 10 VM
• I was able to resume an ArchLinux VM

Kernel: Linux nixo-t14s 5.10.4 #1-NixOS SMP Wed Dec 30 10:54:29 UTC 2020 x86_64 GNU/Linux

Thanks for testing!

Guys just to update, I included the relevant patches from svn referecing this issue (the 3 that @blitz linked here) I and did get a bunch of compile errors, this week has been a little to busy so I did not have enough time to debug yet , so sorry for that.

Guys just to update, I included the relevant patches from svn referecing this issue (the 3 that @blitz linked here) I and did get a bunch of compile errors, this week has been a little to busy so I did not have enough time to debug yet , so sorry for that.

No worries. The easiest option would be to wait until the VBox people make a new release that includes these fixes. That would spare us the pain of backporting. They had a "once-per-month" cadence, but only until October. Not sure what's happening on their end that prevents a new release. I would guess though that NixOS is not the only customer poking them about 5.10.

If having a potentially slightly b0rken VirtualBox on Linux 5.10 is better than no VirtualBox at all, I'd be in favor of only using the partial backport from the original bug report.

Guys, I think I managed to fix the errors, it seems that there was something with the drm patch that was failing in the vbox_ttm.c file plus some other QT things that I was messing with.

I used a fragment of Sergio's git patch(sergiomb2/VirtualBox@b6c765d) and it worked via nix-build, I switched to unstable banch and cherry-picked the current commit, I will leave it here doing it's magic and report it as soon as it finish.

For testing you can use a override, overlay or just cherry-pick the latest commit.

Example with override in configuration.nix:

nixpkgs = {
    config = {
      allowUnfree = true;
      packageOverrides = pkgs: rec {
        virtualbox = pkgs.virtualbox.overrideAttrs (attrs: {
          patches = attrs.patches
            ++ [ /root/linux-5.10-r0drv-memobj-fix-r0.patch /root/linux-5.10-regops.patch /root/linux-5.10-drm.patch ];
        });
        #xen = pkgs.xen.overrideAttrs (attrs: {
        #  patches = attrs.patches
        #    ++ [ /root/xen-tools-4.13.0-ipxe-gcc10.patch ];
        #});
      };
    };
  };

Make sure to have the files at the described path.

Guys, in the current master my system build fails with a package not related to Virtualbox, in the branch that I committed the build is working 100%.

I did all the tests that I mentioned in the original issue, on my side everything is functional.

New version 6.18 is released. I think we can move on to that now.

New version 6.18 is released. I think we can move on to that now.

One word to that, LOL.

@Magicloud you will a open a PR?

FWIW I have been using the changes from this PR for a while and it's working fine. I have tested the latest changes now and it still builds and works fine.

Can we bump to 6.18 directly, if it's released and fixes it too?

Can we bump to 6.18 directly, if it's released and fixes it too?

Yep!

6.1.18 already fixes this issue.

FWIW I have been using the changes from this PR for a while and it's working fine. I have tested the latest changes now and it still builds and works fine.

Thanks! :D

I tried the easy way but update.sh is not working for me, with the error:

++ cut -f1 '-d '
++ grep -w '*VBoxGuestAdditions_6.1.18.iso'
+ guestAdditionsShaSum=904432eb331d7ae517afaa4e4304e6492b7947b46ecb8267de7ef792c4921b4c
++ nixFile virtualbox
++ sed -re 's/^"(.*):[0-9]+"$/\1/'
++ nix-instantiate --eval --strict -A virtualbox.meta.position
error: cannot auto-call a function that has an argument without a default value ('config')
+ virtualboxNixFile=

I will try to update by hand.

Opened #110550.

@bryanasdev000 appreciate the effort you made on this PR, I've also been using the upstream patch with your changes.

@bryanasdev000 appreciate the effort you made on this PR, I've also been using the upstream patch with your changes.

Thanks @gvolpe!

Happy to help!