Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

anbox: unstable-2019-11-15 -> unstable-2020-11-29 #108351

Merged
merged 1 commit into from Jan 5, 2021
Merged

anbox: unstable-2019-11-15 -> unstable-2020-11-29 #108351

merged 1 commit into from Jan 5, 2021

Conversation

fabianhjr
Copy link
Member

@fabianhjr fabianhjr commented Jan 3, 2021 •
edited

Motivation for this change

Update to unbreak after gcc10 / binutils 2.34 update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from edwtjo January 3, 2021 22:04
@thiagokokada
Copy link
Contributor

thiagokokada commented Jan 4, 2021 •
edited

Result of nixpkgs-review pr 108351 1

1 package built:
  • anbox

Builds and I ran some commands. It failed to start a VM but it looks like I need the module enabled (and I don't have it).

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/324

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108351 run on x86_64-linux 1

1 package built:
  • anbox

@thiagokokada
Copy link
Contributor

You can also use https://github.com/timokau/marvin-mk2/blob/master/USAGE.md to help your PR to be merged.

@fabianhjr
Copy link
Member Author

/marvin opt-in
/status needs_merger

@marvin-mk2
Copy link

marvin-mk2 bot commented Jan 5, 2021

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2 marvin-mk2 bot added the marvin label Jan 5, 2021
@marvin-mk2
Copy link

marvin-mk2 bot commented Jan 5, 2021

The PR author cannot set the status to needs_merger. Please wait for an external review.

If you are not the PR author and you are reading this, please review the usage of this bot. You may be able to help. Please make an honest attempt to resolve all outstanding issues before setting to needs_merger.

@thiagokokada
Copy link
Contributor

You need to use needs_reviewer, someone else uses needs_merger.

/status needs_merger

@marvin-mk2 marvin-mk2 bot requested a review from kevincox January 5, 2021 19:15
@kevincox kevincox merged commit d897e8e into NixOS:master Jan 5, 2021
@fabianhjr fabianhjr deleted the update-anbox branch October 14, 2021 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagokokada thiagokokada thiagokokada approved these changes

@edwtjo edwtjo Awaiting requested review from edwtjo

@kevincox kevincox Awaiting requested review from kevincox

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 awaiting_merger marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fabianhjr @thiagokokada @nixos-discourse @SuperSandro2000 @kevincox