Skip to content

treewide: Inline more of the static overlay #108350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2021
Merged

treewide: Inline more of the static overlay #108350

merged 1 commit into from
Jan 5, 2021
+64 −106

Conversation

Ericson2314
Copy link
Member

Motivation for this change

Picking up where #107238 left off. I think I'll have gotten all the easy stuff with this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@Ericson2314
treewide: Inline more of the static overlay

Verified

This commit was signed with the committer’s verified signature.
bagder Daniel Stenberg
GPG key ID: 5CC908FDB71E12C2
Verified
Learn about vigilant mode
5c29651 
Picking up where NixOS#107238 left off. I think I'll have gotten all the easy
stuff with this.
@Ericson2314 Ericson2314 requested a review from FRidh as a code owner January 3, 2021 21:47
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108350 run on x86_64-darwin 1

26 packages marked as broken and skipped:
  • contrast
  • crowbar
  • fractal
  • gnome-podcasts
  • gnome3.gedit
  • gscan2pdf
  • jellyfin-mpv-shim
  • kodiPlugins.inputstream-adaptive
  • kodiPlugins.joystick
  • kodiPlugins.pvr-hdhomerun
  • kodiPlugins.pvr-hts
  • kodiPlugins.pvr-iptvsimple
  • kodiPlugins.steam-controller
  • kodiPlugins.vfs-libarchive
  • kodiPlugins.vfs-sftp
  • malcontent-ui
  • newsflash
  • python37Packages.py3status
  • python37Packages.pyslurm
  • python38Packages.py3status
  • python38Packages.pyslurm
  • python39Packages.py3status
  • python39Packages.pyslurm
  • run-scaled
  • virtscreen
  • yaxg
15 packages failed to build and are new build failures:
12 packages built:
  • deco
  • girara
  • python37Packages.dogtail
  • python38Packages.dogtail
  • python39Packages.dogtail
  • tightvnc
  • xorg.xauth
  • xorg.xdpyinfo
  • xorg.xinit
  • xquartz
  • xvfb_run
  • zathura

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108350 run on x86_64-linux 1

12 packages marked as broken and skipped:
  • clfswm
  • gnome3.gnome-books
  • gnome3.gnome-documents
  • gscan2pdf
  • libsForQt512.discover
  • libsForQt514.discover
  • python37Packages.pyslurm
  • python38Packages.pyslurm
  • python39Packages.pyslurm
  • stumpwm
  • stumpwm-git
  • vimiv
2 packages blacklisted:
  • tests.nixos-functions.nixos-test
  • tests.nixos-functions.nixosTest-test
29 packages failed to build and are new build failures:
236 packages built:
  • adapta-gtk-theme
  • akira-unstable
  • almanah
  • amtk
  • autokey
  • autotiling
  • balsa
  • betterlockscreen
  • caffeine-ng
  • calls
  • chrome-gnome-shell
  • compcert
  • contrast
  • coqPackages.contribs.zorns-lemma
  • coq_8_10
  • coq_8_11
  • coq_8_12
  • coq_8_13
  • crowbar
  • deco
  • deja-dup
  • denemo
  • dockbarx
  • ephemeral
  • epiphany (gnome3.epiphany)
  • feeds
  • flashfocus
  • flatpak
  • flatpak-builder
  • flent
  • fractal
  • framac
  • gImageReader
  • gajim
  • genxword
  • girara
  • gitg (gnome3.gitg)
  • gjs (gnome3.gjs)
  • gksu
  • glade (gnome3.glade)
  • gnome-builder
  • gnome-latex
  • gnome-passwordsafe
  • gnome-photos (gnome3.gnome-photos)
  • gnome-podcasts
  • gnome-tour
  • gnome-usage (gnome3.gnome-usage)
  • gnome3.accerciser
  • gnome3.anjuta
  • gnome3.bijiben (gnome3.gnome-notes)
  • gnome3.devhelp
  • gnome3.geary
  • gnome3.gedit
  • gnome3.gnome-calculator
  • gnome3.gnome-calendar
  • gnome3.gnome-characters
  • gnome3.gnome-clocks
  • gnome3.gnome-contacts
  • gnome3.gnome-control-center (gnome3.gnome_control_center)
  • gnome3.gnome-initial-setup
  • gnome3.gnome-maps
  • gnome3.gnome-music
  • gnome3.gnome-screenshot
  • gnome3.gnome-session (gnome3.gnome_session)
  • gnome3.gnome-shell (gnome3.gnome_shell)
  • gnome3.gnome-software
  • gnome3.gnome-sound-recorder
  • gnome3.gnome-terminal (gnome3.gnome_terminal)
  • gnome3.gnome-tweaks (gnome3.gnome-tweak-tool)
  • gnome3.gnome-weather
  • gnome3.gpaste
  • gtksourceview (gnome3.gtksourceview ,gtksourceview3 ,xfce.gtksourceview)
  • gtksourceview4 (gnome3.gtksourceview4)
  • gtksourceviewmm (gnome3.gtksourceviewmm)
  • libdazzle (gnome3.libdazzle)
  • meld (gnome3.meld)
  • gnome3.mutter
  • pantheon.mutter (gnome3.mutter334)
  • nemiver (gnome3.nemiver)
  • gnome3.polari
  • gnome3.pomodoro
  • gnome3.seahorse
  • gnome3.sushi
  • gnomeExtensions.drop-down-terminal
  • gnomeExtensions.easyScreenCast
  • gnomeExtensions.gsconnect
  • gnomeExtensions.night-theme-switcher
  • gnomeExtensions.system-monitor
  • gnunet-gtk
  • gobby5
  • gretl
  • gtg
  • gtkpod
  • gtksourceviewmm4
  • gtranslator
  • gummi
  • gupnp-tools
  • haskellPackages.gi-gtksource
  • haskellPackages.gi-ostree
  • i3
  • i3-balance-workspace
  • i3-gaps
  • i3-layout-manager
  • i3-resurrect
  • i3-wk-switch
  • i3altlayout
  • jellyfin-mpv-shim
  • kmymoney
  • libgksu
  • libhandy
  • libhandy_0
  • plasma5.discover (libsForQt5.discover)
  • lollypop
  • lutris
  • lutris-free
  • malcontent-ui
  • marker
  • mate.mate-applets
  • mate.mate-tweak
  • mate.pluma
  • minder
  • minishift
  • monitor
  • multilockscreen
  • neap
  • newsflash
  • notejot
  • notes-up
  • ocaml-top
  • ostree
  • pantheon.elementary-code
  • pantheon.elementary-greeter
  • pantheon.elementary-gsettings-schemas
  • pantheon.elementary-onboarding
  • pantheon.elementary-session-settings
  • pantheon.gala
  • pantheon.notes-up
  • pantheon.sideload
  • pantheon.switchboard-plug-pantheon-shell
  • pantheon.switchboard-with-plugs
  • pantheon.wingpanel
  • pantheon.wingpanel-applications-menu
  • pantheon.wingpanel-indicator-bluetooth
  • pantheon.wingpanel-indicator-datetime
  • pantheon.wingpanel-indicator-keyboard
  • pantheon.wingpanel-indicator-network
  • pantheon.wingpanel-indicator-nightlight
  • pantheon.wingpanel-indicator-notifications
  • pantheon.wingpanel-indicator-power
  • pantheon.wingpanel-indicator-session
  • pantheon.wingpanel-indicator-sound
  • pantheon.wingpanel-with-indicators
  • paperwork
  • ping
  • plover.dev
  • plover.stable
  • polybarFull
  • powerline (python38Packages.powerline)
  • pspp
  • python37Packages.dogtail
  • python37Packages.ewmh
  • python37Packages.i3ipc
  • python37Packages.liblarch
  • python37Packages.powerline
  • python37Packages.py3status
  • python37Packages.pynput
  • python37Packages.pystray
  • python37Packages.pywebview
  • python37Packages.ueberzug
  • python37Packages.xlib
  • python38Packages.dogtail
  • python38Packages.ewmh
  • python38Packages.i3ipc
  • python38Packages.liblarch
  • python38Packages.py3status
  • python38Packages.pynput
  • python38Packages.pystray
  • python38Packages.pywebview
  • ueberzug (python38Packages.ueberzug)
  • xdot (python38Packages.xdot)
  • python38Packages.xlib
  • python39Packages.dogtail
  • python39Packages.ewmh
  • python39Packages.i3ipc
  • python39Packages.liblarch
  • python39Packages.py3status
  • python39Packages.pystray
  • python39Packages.pywebview
  • python39Packages.ueberzug
  • python39Packages.xlib
  • quilter
  • quodlibet
  • quodlibet-full
  • quodlibet-without-gst-plugins
  • quodlibet-xine
  • quodlibet-xine-full
  • rabbitvcs
  • raiseorlaunch
  • rednotebook
  • remarkable-mouse
  • rpm-ostree
  • run-scaled
  • safeeyes
  • satallax
  • screenfetch
  • setzer
  • shortwave
  • slurm
  • slurm-spank-x11
  • sway-contrib.inactive-windows-transparency
  • sysprof
  • tepl
  • tigervnc
  • tightvnc
  • vala-language-server
  • virt-manager
  • virtscreen
  • why3
  • x11docker
  • x11vnc
  • x2goserver
  • xdg-desktop-portal
  • xdg-desktop-portal-gtk
  • xfce.mousepad
  • xfce.xfce4-dockbarx-plugin (xfce.xfce4_dockbarx_plugin)
  • xkb-switch-i3
  • xorg.xauth
  • xorg.xdpyinfo
  • xorg.xinit
  • xpad
  • xpra
  • xrdp
  • xtrace
  • xvfb_run
  • yaxg
  • zathura

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

dockbarx:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
i3altlayout:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
jellyfin-mpv-shim:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
mate.mate-tweak:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
paperwork:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
raiseorlaunch:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
remarkable-mouse:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
xdot:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
dockbarx:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
i3altlayout:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
jellyfin-mpv-shim:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
mate.mate-tweak:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
paperwork:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
raiseorlaunch:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
remarkable-mouse:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
xdot:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
dockbarx:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
i3altlayout:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
jellyfin-mpv-shim:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
mate.mate-tweak:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
paperwork:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
raiseorlaunch:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
remarkable-mouse:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
xdot:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
dockbarx:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
i3altlayout:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
jellyfin-mpv-shim:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
mate.mate-tweak:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
paperwork:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
raiseorlaunch:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
remarkable-mouse:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
xdot:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.

@Ericson2314
Copy link
Member Author

Oh the hash changes are because some preConfigure became unconditional. Eh, the medicine is worse than the disease for that one.

@Ericson2314 Ericson2314 merged commit 4a6916a into NixOS:master Jan 5, 2021
@Ericson2314 Ericson2314 deleted the no-static-overlay branch January 5, 2021 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ericson2314 @SuperSandro2000