Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/redis: add test for unix socket access #108337

Closed
wants to merge 2 commits into from
Closed

nixos/redis: add test for unix socket access #108337

wants to merge 2 commits into from

Conversation

dadada
Copy link
Contributor

@dadada dadada commented Jan 3, 2021 •
edited

Makes the redis unix socket accessible to the redis group. This group
was added in #90027.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dadada dadada force-pushed the dadada/redis-unix-socket branch 3 times, most recently from 7cec46e to cc71e82 Compare January 3, 2021 19:46
@dadada
nixos/redis: change unix socket permissions
5ead42f 
This makes the redis unix socket accessible to the `redis` group. This group
was added in NixOS#90027.
@dadada dadada force-pushed the dadada/redis-unix-socket branch 3 times, most recently from bb6956d to f2e7390 Compare January 3, 2021 21:22
@dadada dadada requested a review from flokli January 3, 2021 21:31
@dadada dadada marked this pull request as ready for review January 3, 2021 21:31
@dadada dadada changed the title nixos/redis: change unix socket permissions Draft: nixos/redis: change unix socket permissions Jan 4, 2021
@dadada dadada changed the title Draft: nixos/redis: change unix socket permissions nixos/redis: change unix socket permissions Jan 4, 2021
@dadada dadada marked this pull request as draft January 4, 2021 18:11
@dadada dadada marked this pull request as ready for review January 4, 2021 18:22
@dadada dadada changed the title nixos/redis: change unix socket permissions nixos/redis: add option for unix socket permissions Jan 4, 2021
@aanderse
Copy link
Member

aanderse commented Jan 4, 2021

@flokli I think it might make more sense to add a settings option here... any opinions on that?

@aanderse aanderse mentioned this pull request Jan 5, 2021
Merged
10 tasks
@dadada dadada changed the title nixos/redis: add option for unix socket permissions nixos/redis: add test for unix socket access Jan 9, 2021
@dadada
Copy link
Contributor Author

dadada commented Jan 9, 2021

Closing in favor of #108440

@dadada dadada closed this Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli Awaiting requested review from flokli

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dadada @aanderse