pdfpc: 4.4.1 -> 4.5.0 #108307
Merged
pdfpc: 4.4.1 -> 4.5.0 #108307
+7
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdlayher
approved these changes
Jan 3, 2021
There was a problem hiding this comment.
LGTM.
$ nixpkgs-review pr 108307
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0 pull/108307/head:refs/nixpkgs-review/1
remote: Enumerating objects: 5, done.
remote: Counting objects: 100% (5/5), done.
remote: Total 7 (delta 5), reused 5 (delta 5), pack-reused 2
Unpacking objects: 100% (7/7), 660 bytes | 330.00 KiB/s, done.
From ssh://github.com/NixOS/nixpkgs
2497a55f5f0..4d0e996b71d master -> refs/nixpkgs-review/0
168f36153b1..9d0164d53d4 refs/pull/108307/head -> refs/nixpkgs-review/1
$ git worktree add /home/matt/.cache/nixpkgs-review/pr-108307/nixpkgs 4d0e996b71d48ac0155ffc0a4de38a4c4743debd
Preparing worktree (detached HEAD 4d0e996b71d)
HEAD is now at 4d0e996b71d Merge pull request #108303 from siraben/codec2-darwin
$ git merge --no-commit 9d0164d53d42417e19f9cea858801fef2cf01768
Automatic merge went well; stopped before committing as requested
$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/matt/.cache/nixpkgs-review/pr-108307/build.nix
[3 built, 266 copied (1103.2 MiB), 245.2 MiB DL]
https://github.com/NixOS/nixpkgs/pull/108307
1 package built:
pdfpc
$ nix-shell /home/matt/.cache/nixpkgs-review/pr-108307/shell.nix
these paths will be fetched (0.51 MiB download, 2.47 MiB unpacked):
/nix/store/8fmzmylr9l60yir9qzixyksrfdshnan6-bash-interactive-4.4-p23-doc
/nix/store/i539vammbyynzv6rh55aq5l79k79awcx-bash-interactive-4.4-p23-dev
/nix/store/j9bq7mdvqrncsk9bprbc47gcwr422k94-bash-interactive-4.4-p23-man
/nix/store/qd5vfykrf9cag5swl66rg5b10jlpzmwb-bash-interactive-4.4-p23-info
copying path '/nix/store/8fmzmylr9l60yir9qzixyksrfdshnan6-bash-interactive-4.4-p23-doc' from 'https://cache.nixos.org'...
copying path '/nix/store/i539vammbyynzv6rh55aq5l79k79awcx-bash-interactive-4.4-p23-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/qd5vfykrf9cag5swl66rg5b10jlpzmwb-bash-interactive-4.4-p23-info' from 'https://cache.nixos.org'...
copying path '/nix/store/j9bq7mdvqrncsk9bprbc47gcwr422k94-bash-interactive-4.4-p23-man' from 'https://cache.nixos.org'...
pSub
approved these changes
Jan 3, 2021
|
Thanks for this update! |
|
Thanks for noticing that. I'm sending a PR with an update. |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
New upstream version.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)