-
-
Notifications
You must be signed in to change notification settings - Fork 15.5k
prometheus-mpd-exporter: init at 0.1.0 #108342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prometheus-mpd-exporter: init at 0.1.0 #108342
Conversation
extraOpts = { | ||
port = mkOption { | ||
type = types.port; | ||
default = "9123"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
rustPlatform.buildRustPackage rec { | ||
pname = "prometheus-mpd-exporter"; | ||
version = "v0.1.0"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
version = "v0.1.0"; | |
version = "0.1.0"; |
|
||
src = fetchgit { | ||
url = "https://git.beyermatthi.as/prometheus-mpd-exporter"; | ||
rev = version; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rev = version; | |
rev = "v${version}"; |
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 1 package blacklisted:
1 package built:
|
4ab13a5
to
f15fc7d
Compare
maintainers = with maintainers; [ matthiasbeyer ]; | ||
}; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the extra 2 new lines.
|
||
cargoSha256 = "0snrfcjawla9ra40x22w5zrr8xnsyhlyj21di8gp5wzf0yj1a9n1"; | ||
|
||
nativeBuildInputs = [ pkg-config openssl ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if it links against openssl it need to go to buildInputs.
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
f15fc7d
to
7b2fe9d
Compare
port = mkOption { | ||
type = types.port; | ||
default = "9806"; | ||
description = '' | ||
Port to bind to | ||
''; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
port = mkOption { | |
type = types.port; | |
default = "9806"; | |
description = '' | |
Port to bind to | |
''; | |
}; |
port
is a default option, it is already defined in exporters.nix
I am interested in this software being in nixpkgs. May someone fill me in, why this merge request was closed? |
Because I don't care enough. I compile it myself in my |
Motivation for this change
Wrote this today and would find it useful if it were in nixpkgs. Others might be interested as well.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)I don't know how to properly test the service, but I have a similar service already running on two of my machines.