Cool. I generally rebase and force-push, because I don't think nixos squashes PR commits in its repos. Hopefully someone with merge rights can merge it in after that.

@joshuaclayton you might be interested in this.

@lrworth ah, neat! I just pushed a new commit in as of yesterday to better support non-UTF-8 tags files (this was an issue in the Haskell version as well: joshuaclayton/unused#72).

I'm going to cut a 0.2 release in the next few minutes (in case it's not too much trouble to include that rather than 0.1) since I'm guessing it may be a sticking point for folks.

Great! Let's wait until 0.2 then.

@lrworth on second thought, I'm still seeing issues with mimalloc compiling on ubuntu correctly in GH actions: https://github.com/unused-code/unused/runs/1574360688?check_suite_focus=true

Until I work that out, I think we'll be on pause for a 0.2 release (mimalloc cuts execution time by 30%+ here, so I don't want to out-right remove it without investigating further).

I spoke too soon – I was able to cut 0.2.0, available here.

Updated to 0.2.0, which also seems to have resolved the yaml problem and let us use rustPackages.

I'll bump promptly when and if unused-code/unused#25 is resolved.

Still builds and runs on NixOS with the new version

It is recommended by many that the changes made to maintainer-list.nix be put in a separate commit with a commit message "maintainer-list: add lrworth"

Result of nixpkgs-review pr 107077 run on x86_64-darwin 1

Closed as there is no maintainer for this package.

@SuperSandro2000 those fields are optional on purpose, and we don't need to force contributors to fill them in if they don't want to. @lrworth can contribute this package as a maintainer, without filling them all in if they would like to.

Thanks @grahamc. Let's try this again then?

@SuperSandro2000 those fields are optional on purpose, and we don't need to force contributors to fill them in if they don't want to. @lrworth can contribute this package as a maintainer, without filling them all in if they would like to.

Sorry about this. I just wanted to convince the author to add this informations. The information is tied to his commit anyway.

@lrworth @grahamc @endgame @SuperSandro2000 thanks for helping get this merged!

@lrworth I haven't used Nix yet (still on MacOS Homebrew) – if you have a few minutes, I'd very much appreciate a PR to unused highlighting how to install so others can take advantage of this as well.

Nix instructions in README.md: unused-code/unused#26