Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brave: 1.17.73 -> 1.18.70 #107082

Closed
wants to merge 1 commit into from
Closed

brave: 1.17.73 -> 1.18.70 #107082

wants to merge 1 commit into from

Conversation

JeffLabonte
Copy link
Contributor

@JeffLabonte JeffLabonte commented Dec 17, 2020 •
edited

Motivation for this change

Keep the browser up-to-date. Version not in the range of https://nvd.nist.gov/vuln/detail/CVE-2020-8276

#106186

Things done

Update package version from 1.17.73 to 1.18.70

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from rht and uskudnik December 17, 2020 04:57
@buckley310
Copy link
Contributor

duplicate
#106718

@JeffLabonte
Copy link
Contributor Author

JeffLabonte commented Dec 17, 2020 •
edited

@buckley310 Sorry, my bad. For some reason, I am not getting notified anymore on PR that I maintain.

@worldofpeace could you add me to the contributor team so I can get notified of such things 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rht rht Awaiting requested review from rht

@uskudnik uskudnik Awaiting requested review from uskudnik

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JeffLabonte @buckley310