Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.haskell-language-server: 0.6.0 -> 0.7.0 #107078

Merged
merged 2 commits into from Dec 17, 2020
Merged

haskellPackages.haskell-language-server: 0.6.0 -> 0.7.0 #107078

merged 2 commits into from Dec 17, 2020

Conversation

expipiplus1
Copy link
Contributor

Supersedes #106705

Remove hls-brittany as it's no longer necessary

Fix the update script to include hls-explicit-imports-plugin and
hls-retrhls-retrie-plugin

CC @maralorn

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@expipiplus1
haskellPackages.haskell-language-server: 0.6.0 -> 0.7.0
496863f 
Remove hls-brittany as it's no longer necessary

Fix the update script to include hls-explicit-imports-plugin and
hls-retrhls-retrie-plugin
@expipiplus1
haskell-language-server: Make update.sh fetch latest tagged release
eb4b8d2
@expipiplus1 expipiplus1 mentioned this pull request Dec 17, 2020
Closed
10 tasks
@maralorn
Copy link
Member

Marvelous! I have tested this, it works, the PR looks fine, too.

@maralorn maralorn merged commit 8764ced into NixOS:haskell-updates Dec 17, 2020
@expipiplus1
Copy link
Contributor Author

If you liked that then you'll love this: #107128

@maralorn
Copy link
Member

You know me better than my amazon account does. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

Assignees
No one assigned
Labels
6.topic: haskell 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@expipiplus1 @maralorn