Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode: 1.51.1 -> 1.52.1 #107076

Merged
merged 1 commit into from Dec 24, 2020
Merged

vscode: 1.51.1 -> 1.52.1 #107076

merged 1 commit into from Dec 24, 2020

Conversation

samuela
Copy link
Member

@samuela samuela commented Dec 17, 2020

Motivation for this change

Upgrades vscode from 1.51.1 to 1.52.1

This PR was automatically generated by nixpkgs-upkeep.

  • CI workflow that created this PR.
  • Internal tag: be18e71cb4d013e037ddf2b4a3424571.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from Synthetica9 and eadwu December 17, 2020 00:32
@samuela samuela mentioned this pull request Dec 17, 2020
Closed
10 tasks
@matklad
Copy link
Member

matklad commented Dec 18, 2020

Works on nixos-unstable for me!

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/speeding-up-vs-code-update-merges/10652/1

jonringer
jonringer approved these changes Dec 24, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
gui launches fine

https://github.com/NixOS/nixpkgs/pull/107076

2 packages built:
vscode vscode-with-extensions

@jonringer jonringer merged commit e24bf90 into NixOS:master Dec 24, 2020
@samuela samuela deleted the upkeep-bot/vscode-1.52.1-1608164550 branch December 24, 2020 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otavio otavio otavio approved these changes

@jonringer jonringer jonringer approved these changes

@Synthetica9 Synthetica9 Awaiting requested review from Synthetica9

@eadwu eadwu Awaiting requested review from eadwu

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@samuela @matklad @nixos-discourse @otavio @jonringer