Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/zabbixWeb: include DOUBLE_IEEE754 directive #107064

Merged
merged 1 commit into from Dec 28, 2020
Merged

nixos/zabbixWeb: include DOUBLE_IEEE754 directive #107064

merged 1 commit into from Dec 28, 2020

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Dec 16, 2020 •
edited

Motivation for this change

This was missed in the PR that bumped zabbixWeb to 5.x. It is safe to backport to release-20.09 and will benefit new zabbixWeb installs.

https://www.zabbix.com/documentation/5.0/manual/installation/upgrade_notes_500

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse aanderse marked this pull request as ready for review December 17, 2020 21:50
@aanderse aanderse added the 9.needs: port to stable A PR needs a backport to the stable release. label Dec 20, 2020
@aanderse aanderse merged commit a08ed09 into NixOS:master Dec 28, 2020
@aanderse aanderse deleted the nixos/zabbixWeb branch December 28, 2020 05:22
@aanderse aanderse mentioned this pull request Dec 28, 2020
Merged
10 tasks
@erictapen erictapen added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@symphorien symphorien symphorien left review comments

@PsyanticY PsyanticY Awaiting requested review from PsyanticY

@mmahut mmahut Awaiting requested review from mmahut

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aanderse @symphorien @erictapen