Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libsolv: Enable darwin support. #107081

Merged
merged 1 commit into from Dec 17, 2020
Merged

libsolv: Enable darwin support. #107081

merged 1 commit into from Dec 17, 2020

Conversation

rb2k
Copy link
Contributor

@rb2k rb2k commented Dec 17, 2020

Motivation for this change

This already compiles fine, no changes necesssary.
I am currently working on getting DNF to compile on darwin (long story) and this is one of the less problematic dependencies :)

Example:

/nix/store/r4i8ba7cjzr1nczsqw8p9i2mjcjqifkb-libsolv-0.7.16/bin/installcheck: <arch> [options..] repo [--nocheck repo]...
	--exclude <pattern>	whitespace-separated list of (sub-)packagenames to ignore
	--withobsoletes		Check for obsoletes on packages contained in repos
	--nocheck		Do not warn about all following repos (only use them to fulfill dependencies)
	--withsrc		Also check dependencies of src.rpm
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@LnL7 LnL7 merged commit ed0b34b into NixOS:master Dec 17, 2020
@rb2k rb2k deleted the libsolv_darwin branch December 17, 2020 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants