Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.arbtt: unbreak #108460

Merged
merged 1 commit into from Jan 6, 2021
Merged

haskellPackages.arbtt: unbreak #108460

merged 1 commit into from Jan 6, 2021

Conversation

markus1189
Copy link
Contributor

Thanks to nomeata/arbtt#43 arbtt now builds successfully 馃帀

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@markus1189
haskellPackages.arbtt: unbreak
a9acf8e 
Thanks to nomeata/arbtt#43 `arbtt` now
builds successfully 馃帀
sternenseemann
sternenseemann approved these changes Jan 5, 2021
View reviewed changes
Copy link
Member

@sternenseemann sternenseemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on x86_64-linux.

@cdepillabout
Copy link
Member

Thanks!

@cdepillabout cdepillabout merged commit d89f456 into NixOS:haskell-updates Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sternenseemann sternenseemann sternenseemann approved these changes

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@markus1189 @cdepillabout @sternenseemann