Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[staging] python38: remove obsolete find_library patch #108430

Merged
merged 1 commit into from Jan 4, 2021
Merged

[staging] python38: remove obsolete find_library patch #108430

merged 1 commit into from Jan 4, 2021

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 4, 2021 •
edited

Motivation for this change

fixes python38 on staging

was missed in: #107725

patching file Lib/ctypes/test/test_find.py
Reversed (or previously applied) patch detected!  Assume -R? [n]
Apply anyway? [n]
Skipping patch.
3 out of 3 hunks ignored -- saving rejects to file Lib/ctypes/test/test_find.py.rej
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer requested a review from FRidh as a code owner January 4, 2021 22:08
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python38Packages.requests

@jonringer jonringer mentioned this pull request Jan 4, 2021
Merged
10 tasks
TredwellGit
TredwellGit approved these changes Jan 4, 2021
View reviewed changes
Copy link
Member

@TredwellGit TredwellGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built python38Packages.requests.

@jonringer
Copy link
Contributor Author

jonringer commented Jan 4, 2021 •
edited

python38Packages.requests was built by ofborg. Seeing as all of python3Packages, including stdenv (through python3Minimal) is broken on staging, I'm going to merge

@jonringer jonringer merged commit 1617403 into NixOS:staging Jan 4, 2021
@jonringer jonringer deleted the fix-python38 branch January 4, 2021 23:44
@jonringer jonringer mentioned this pull request Jan 5, 2021
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TredwellGit TredwellGit TredwellGit approved these changes

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @TredwellGit