Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/redis: replace extraConfig option with settings option #108440

Merged
merged 1 commit into from Jan 7, 2021
Merged

nixos/redis: replace extraConfig option with settings option #108440

merged 1 commit into from Jan 7, 2021

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Jan 5, 2021

Motivation for this change

Either replace or supplement #108337.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dadada
Copy link
Contributor

dadada commented Jan 6, 2021

I'll rebase the tests from my PR onto this change. Doing this with settings seems like the right way.

flokli
flokli approved these changes Jan 7, 2021
View reviewed changes
Copy link
Contributor

@flokli flokli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

dadada
dadada approved these changes Jan 7, 2021
View reviewed changes
Copy link
Contributor

@dadada dadada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@flokli flokli merged commit 9414948 into NixOS:master Jan 7, 2021
@aanderse aanderse deleted the nixos/redis branch January 7, 2021 23:40
This was referenced Jan 9, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli flokli approved these changes

@dadada dadada dadada approved these changes

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aanderse @dadada @flokli