Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postgresql: add passthru.tests #108449

Merged
merged 1 commit into from Jan 9, 2021
Merged

postgresql: add passthru.tests #108449

merged 1 commit into from Jan 9, 2021

Conversation

Ekleog
Copy link
Member

@Ekleog Ekleog commented Jan 5, 2021

Add passthru.tests so that postgresql gets tested more.

cc @thoughtpolice @danbst @globin @marsam @pacien @lovesegfault for respectively maintainership of the postgresql package, of the postgresql-wal-receiver nixos test, and for having noticed the initial issue.

Hopefully ofborg will know which packages to test-build because I'm not sure I got them all, even though the change should only affect passthru and thus not even trigger a rebuild.

@Ekleog
Copy link
Member Author

Ekleog commented Jan 5, 2021

Hmm well, looks like ofborg doesn't actually know the package list, let's ask for them all

@ofborg build postgresql_9_5 postgresql_9_5.tests postgresql_9_6 postgresql_9_6.tests postgresql_10 postgresql_10.tests postgresql_11 postgresql_11.tests postgresql_12 postgresql_12.tests postgresql_13 postgresql_13.tests

@Ekleog
Copy link
Member Author

Ekleog commented Jan 5, 2021

@ofborg build postgresql_9_5

@Ekleog
Copy link
Member Author

Ekleog commented Jan 5, 2021

Hmm maybe I can actually start them only one by one?

@ofborg build postgresqlPackages
@ofborg build postgresql11Packages

@Ekleog
Copy link
Member Author

Ekleog commented Jan 5, 2021

With that all builds should be started

@ofborg build postgresql_9_5.tests
@ofborg build postgresql_9_6
@ofborg build postgresql_9_6.tests
@ofborg build postgresql_10
@ofborg build postgresql_10.tests
@ofborg build postgresql_11
@ofborg build postgresql_11.tests
@ofborg build postgresql_12
@ofborg build postgresql_12.tests
@ofborg build postgresql_13
@ofborg build postgresql_13.tests

@Ekleog
Copy link
Member Author

Ekleog commented Jan 9, 2021

Well let's land, it can always be reverted if it causes issues or people disagree :)

@Ekleog Ekleog merged commit 94793d3 into NixOS:master Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice thoughtpolice is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Ekleog