Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

josm: 17329 → 17428 #108467

Closed
wants to merge 1 commit into from
Closed

josm: 17329 → 17428 #108467

wants to merge 1 commit into from

Conversation

sikmir
Copy link
Member

@sikmir sikmir commented Jan 5, 2021

Motivation for this change

Changelog (2020-12-29: Stable release 17428)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sikmir sikmir requested a review from rycee January 5, 2021 11:06
@mweinelt
Copy link
Member

mweinelt commented Jan 5, 2021

Looks to be working. Starts up, downloads tiles, editing works.

Result of nixpkgs-review pr 108467 run on x86_64-linux 1

1 package built:
  • josm

@rycee
Copy link
Member

rycee commented Jan 5, 2021

Thanks! Rebased to master in 17f6b50.

@rycee rycee closed this Jan 5, 2021
@sikmir sikmir deleted the josm branch January 6, 2021 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@rycee rycee Awaiting requested review from rycee

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sikmir @mweinelt @rycee