Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

marwaita-manjaro: 1.6 -> 1.8 #108421

Merged
merged 1 commit into from Jan 5, 2021
Merged

marwaita-manjaro: 1.6 -> 1.8 #108421

merged 1 commit into from Jan 5, 2021

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Jan 4, 2021

Motivation for this change

Update to version 1.8

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

hugolgst
hugolgst approved these changes Jan 4, 2021
View reviewed changes
Copy link
Member

@hugolgst hugolgst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 108421

1 package updated:
marwaita-manjaro (1.6 → 1.8)

1 package built:
marwaita-manjaro

LGTM

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 108421 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • marwaita-manjaro

@thiagokokada
Copy link
Contributor

Result of nixpkgs-review pr 108421 run on x86_64-linux 1

1 package built:
  • marwaita-manjaro

@romildo
Copy link
Contributor Author

romildo commented Jan 5, 2021

Result of nixpkgs-review pr 108421 run on x86_64-darwin 1
1 package marked as broken and skipped:

* marwaita-manjaro

I do not have access to a darwin machine to test on it.
I do not see any details in https://github.com/NixOS/nixpkgs/pull/108421/checks about building on darwin.
So I do not know why it fails on darwin.

@SuperSandro2000 any clues?

Should the platform to this package be restricted to linux?

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 108421 run on x86_64-darwin 1
1 package marked as broken and skipped:

* marwaita-manjaro

I do not have access to a darwin machine to test on it.
I do not see any details in #108421 (checks) about building on darwin.
So I do not know why it fails on darwin.

@SuperSandro2000 any clues?

Should the platform to this package be restricted to linux?

It is marked as broken because gtk-engines-2.20.2 is. It is fine like this.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108421 run on x86_64-linux 1

1 package built:
  • marwaita-manjaro

@SuperSandro2000 SuperSandro2000 merged commit 35a9015 into NixOS:master Jan 5, 2021
@romildo
Copy link
Contributor Author

romildo commented Jan 5, 2021

Result of nixpkgs-review pr 108421 run on x86_64-darwin 1
1 package marked as broken and skipped:

* marwaita-manjaro

I do not have access to a darwin machine to test on it.
I do not see any details in #108421 (checks) about building on darwin.
So I do not know why it fails on darwin.
@SuperSandro2000 any clues?
Should the platform to this package be restricted to linux?

It is marked as broken because gtk-engines-2.20.2 is. It is fine like this.

Is this kind of failure easy to spot? How would one easily discover for himself that gtk-engines-2.20.2 is the cause here?

@romildo romildo deleted the upd.marwaita-manjaro branch January 5, 2021 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagokokada thiagokokada thiagokokada approved these changes

@hugolgst hugolgst hugolgst approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@romildo @SuperSandro2000 @thiagokokada @hugolgst