Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pywizlight: init at 0.4.1 #108482

Merged
merged 2 commits into from Jan 5, 2021
Merged

python3Packages.pywizlight: init at 0.4.1 #108482

merged 2 commits into from Jan 5, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Jan 5, 2021

Motivation for this change

Python connector for WiZ light bulbs.

https://github.com/sbidy/pywizlight

This is a Home Assistant dependency (to be precise HACS).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabaff fabaff changed the title Pywizlight python3Packages.pywizlight: init at 0.4.1 Jan 5, 2021
jonringer
jonringer approved these changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Link to currently reviewing PR:
https://github.com/NixOS/nixpkgs/pull/108482

6 packages built:
python37Packages.asyncio-dgram python37Packages.pywizlight python38Packages.asyncio-dgram python38Packages.pywizlight python39Packages.asyncio-dgram python39Packages.pywizlight

@jonringer
Copy link
Contributor

please correct:

pkgs/development/python-modules/asyncio-dgram/default.nix:
	21: Trailing whitespace

jonringer
jonringer approved these changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 108482 run on x86_64-linux 1

6 packages built:
  • python37Packages.asyncio-dgram
  • python37Packages.pywizlight
  • python38Packages.asyncio-dgram
  • python38Packages.pywizlight
  • python39Packages.asyncio-dgram
  • python39Packages.pywizlight

@jonringer jonringer merged commit 441c85b into NixOS:master Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fabaff @jonringer