Skip to content

plex: 1.21.1.3795-ee64ab56f -> 1.21.1.3842-b0c7a97d9 #108446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2021
Merged

plex: 1.21.1.3795-ee64ab56f -> 1.21.1.3842-b0c7a97d9 #108446

merged 1 commit into from
Jan 5, 2021
+3 −3

Conversation

badmutex
Copy link
Contributor

@badmutex badmutex commented Jan 5, 2021 •
edited
Loading

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@badmutex badmutex mentioned this pull request Jan 5, 2021
Closed
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 5, 2021
@SuperSandro2000
Copy link
Member

@ofborg eval

@ymarkus ymarkus added the 8.has: package (update) This PR updates a package to a newer version label Jan 5, 2021
@ymarkus
Copy link
Contributor

ymarkus commented Jan 5, 2021

Seems to work on x86_64-linux NixOS

Reviewed points
  • package name fits guidelines
  • package version fits guidelines
  • package build on x86_64-linux
  • executables tested on x86_64-linux

Sorry, something went wrong.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108446 run on x86_64-linux 1

2 packages built:
  • plex
  • plexRaw

@SuperSandro2000 SuperSandro2000 merged commit 5c66df0 into NixOS:master Jan 5, 2021
@badmutex badmutex deleted the badi/update-plex branch January 5, 2021 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Forkk Forkk

@thoughtpolice thoughtpolice

@colemickens colemickens

@LnL7 LnL7

@pjones pjones

Assignees
No one assigned
Labels
8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@badmutex @SuperSandro2000 @ymarkus