Use the located nixfmt binary for formatting. #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Builds were failing ([example]), as `orgmode` doesn't keep all old versions of `org-plus-contrib`. Updated `nixpkgs.url` to 20.09 from 20.03 and ran `nix flake update --recreate-lock-file`. [example]: https://github.com/NixOS/nix-mode/pull/120/checks?check_run_id=1646110624
Allows use with `nixfmt` installed using direnv ([envrc-mode]). Before: 1. `nix-format-buffer` checks for `nixfmt`: `(executable-find nix-nixfmt-bin)` 2. If it's missing, error. Otherwise, disregard the path to `nixfmt` that we just found. 3. Open a new buffer (if using `envrc-mode`, with a totally different `$PATH`) and try to run `nix-nixfmt-bin`. If you had `nixfmt` installed in your direnv but not globally, this gives an error: "Searching for program: No such file or directory, nixfmt". Now, we use the path that we just found and `call-process-region` on that. [envrc-mode]: https://github.com/purcell/envrc
|
I rebased this on #121 so tests would actually run; don't merge this until that is merged. |
|
Alternatively, you could use reformatter.el to wrap Here are some advantages of using
|
|
reformatter.el appears to be written by the author of envrc-mode, so I'd suspect that they work together. I think that's a great idea in the medium term, but would prefer to limit the scope of this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows use with
nixfmtinstalled using direnv (envrc-mode).Before:
nix-format-bufferchecks fornixfmt:(executable-find nix-nixfmt-bin)nixfmtthat we just found.
envrc-mode, with a totally different$PATH) and try to runnix-nixfmt-bin.If you had
nixfmtinstalled in your direnv but not globally, thisgives an error: "Searching for program: No such file or directory, nixfmt".
Now, we use the path that we just found and
call-process-regionon that.