Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Elm from Docbook to Commonmark #108456

Merged
merged 1 commit into from Feb 13, 2021
Merged

Convert Elm from Docbook to Commonmark #108456

merged 1 commit into from Feb 13, 2021

Conversation

siraben
Copy link
Member

@siraben siraben commented Jan 5, 2021 •
edited

Motivation for this change

Closes #105252

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@siraben siraben requested a review from ryantm January 5, 2021 05:37
@siraben
Copy link
Member Author

siraben commented Jan 23, 2021

@ryantm ping

@taku0 taku0 merged commit 3bcfa06 into NixOS:master Feb 13, 2021
@siraben siraben deleted the elm-docs-md branch February 13, 2021 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taku0 taku0 taku0 approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@ryantm ryantm Awaiting requested review from ryantm

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert Elm from Docbook to CommonMark
3 participants
@siraben @taku0 @SuperSandro2000