Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

teleport,teleport.client: 4.2.11 -> 5.1.2 #108487

Merged
merged 1 commit into from Feb 23, 2021
Merged

teleport,teleport.client: 4.2.11 -> 5.1.2 #108487

merged 1 commit into from Feb 23, 2021

Conversation

freezeboy
Copy link
Contributor

Motivation for this change

Upstream update

And split the client tsh binary from the rest to reduce the size for "users" maybe servers could also be shrinked.

I would prefer someone to double check on their setup as it is quite a sensitive software.

Maybe could be also interesting to add a module and a test for it

I am also unsure if it is better for the default derivation to contain only the client or both the client and the server

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from sigma and tomberek January 5, 2021 15:45
SuperSandro2000
SuperSandro2000 reviewed Jan 6, 2021
View reviewed changes
pkgs/servers/teleport/default.nix Outdated
postInstall = ''
mkdir -p $client/bin
cp $out/bin/tsh $client/bin
strip $client/bin/tsh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
strip $client/bin/tsh

pkgs/servers/teleport/default.nix Outdated Show resolved Hide resolved
pkgs/servers/teleport/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108487 run on x86_64-linux 1

1 package built:
  • teleport

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108487 run on x86_64-darwin 1

1 package built:
  • teleport

@freezeboy
Copy link
Contributor Author

I tried to strip everything, and run --help for the teleport app.
If someone with a service running on nixos can check that the binary it working, I'll be grateful

@Church-
Copy link

Church- commented Feb 22, 2021 •
edited

@freezeboy Nifty to see an update finally. I had given up getting it to work due to a bug with submodule cloning of teleports private e submodule a while back.

I have a PR for a module I've been meaning to refactor for ages, try and bang some work out on it this week to move it over to using @infinisil's settings work.

I'll check that the binary works with my teleport module tomorrow sometime after work.

@freezeboy
Copy link
Contributor Author

Currently rebasing to merge with the update available in master

@freezeboy freezeboy changed the title teleport,teleport.client: 4.2.11 -> 5.1.0 teleport,teleport.client: 4.2.11 -> 5.1.2 Feb 23, 2021
@SuperSandro2000 SuperSandro2000 merged commit 41df7c3 into NixOS:master Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigma sigma Awaiting requested review from sigma

@tomberek tomberek Awaiting requested review from tomberek

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@freezeboy @SuperSandro2000 @Church-