Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscodium: Fix invalid download URL (404) #108471

Merged
merged 1 commit into from Jan 5, 2021
Merged

vscodium: Fix invalid download URL (404) #108471

merged 1 commit into from Jan 5, 2021

Conversation

andyrichardson
Copy link
Contributor

Motivation for this change

URL for darwin is invalid

builder for '/nix/store/2gb5xdcf4xscy9kswg35v893ck89ypvj-VSCodium-darwin-1.52.1.zip.drv' failed with exit code 1; last 7 log lines:

  trying https://github.com/VSCodium/vscodium/releases/download/1.52.1/VSCodium-darwin-1.52.1.zip
    % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                   Dload  Upload   Total   Spent    Left  Speed
    0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  curl: (22) The requested URL returned error: 404 Not Found
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from Synthetica9 and turion January 5, 2021 12:30
thiagokokada
thiagokokada approved these changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@thiagokokada thiagokokada left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test a build since I don't have a macOS, but the SHA256 from the link matches:

❯ nix-prefetch-url https://github.com/VSCodium/vscodium/releases/download/1.52.1/VSCodium-darwin-x64-1.52.1.zip
[91.6 MiB DL]
path is '/nix/store/ar2njxkm6xwcicpshdvjxzwaiq9hz8z4-VSCodium-darwin-x64-1.52.1.zip'
168g34v2b8r1pdbnqrs0c0k9aa60n5rspixziywnq7m61i23nlgd

@ymarkus ymarkus added the 6.topic: darwin Running or building packages on Darwin label Jan 5, 2021
@worldofpeace worldofpeace merged commit cce45c7 into NixOS:master Jan 5, 2021
@worldofpeace
Copy link
Contributor

if you could backport this to release-20.09 it would be much appreciated https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#backporting-changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagokokada thiagokokada thiagokokada approved these changes

@worldofpeace worldofpeace worldofpeace approved these changes

@Synthetica9 Synthetica9 Awaiting requested review from Synthetica9

@turion turion Awaiting requested review from turion

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andyrichardson @worldofpeace @thiagokokada @ymarkus