Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

teamviewer: link teamviewer icons #108428

Merged
merged 1 commit into from Jan 5, 2021
Merged

teamviewer: link teamviewer icons #108428

merged 1 commit into from Jan 5, 2021

Conversation

rhoriguchi
Copy link
Contributor

@rhoriguchi rhoriguchi commented Jan 4, 2021

Motivation for this change

It's nice to have desktop icons on GNOME.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@thiagokokada
Copy link
Contributor

thiagokokada commented Jan 5, 2021

Result of nixpkgs-review pr 108428 1

1 package built:
  • teamviewer

Confirmed that the files seems to be in the correct place.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108428 run on x86_64-linux 1

1 package built:
  • teamviewer

@SuperSandro2000 SuperSandro2000 merged commit 39f7da8 into NixOS:master Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants