Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

appimage-run: fix #108426 #108427

Merged
merged 2 commits into from Jan 25, 2021
Merged

appimage-run: fix #108426 #108427

merged 2 commits into from Jan 25, 2021

Conversation

symphorien
Copy link
Member

Fixes #108426
Adds regression tests for this issue and #101137
You can test that it tests the latter by locally reverting 4d51f95

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@symphorien symphorien mentioned this pull request Jan 4, 2021
Closed
@symphorien
Copy link
Member Author

@GrahamcOfBorg test appimage-run

prusnak
prusnak requested changes Jan 5, 2021
View reviewed changes
Copy link
Member

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: change commit message from

add regression test for appimage-run

to

appimage-run: add regression test

@symphorien
appimage-run: add regression test
b28e5f3
@symphorien
appimage-run: don't chdir to the appimage
f54f718 
this allows to pass relative paths to appimages as argument

fixes NixOS#108426
@symphorien
Copy link
Member Author

@prusnak: done

@symphorien symphorien merged commit 7f355dc into NixOS:master Jan 25, 2021
@symphorien symphorien deleted the chdir-appimage branch January 25, 2021 18:18
@symphorien symphorien restored the chdir-appimage branch January 25, 2021 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak requested changes

@bjornfor bjornfor bjornfor approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

appimage-run changes the current working directory
3 participants
@symphorien @prusnak @bjornfor