Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sylk: 2.9.3 -> 2.9.4 #108466

Merged
merged 1 commit into from Jan 5, 2021
Merged

Sylk: 2.9.3 -> 2.9.4 #108466

merged 1 commit into from Jan 5, 2021

Conversation

leenaars
Copy link
Contributor

@leenaars leenaars commented Jan 5, 2021

Motivation for this change

Simple version bump.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested execution of all binary files (usually in ./result/bin/)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from zimbatm January 5, 2021 10:37
@ymarkus
Copy link
Contributor

ymarkus commented Jan 5, 2021

Seems good to me!

Reviewed points
  • package name fits guidelines
  • package version fits guidelines
  • package build on x86_64-linux
  • executables tested on x86_64-linux

@alyssais alyssais merged commit 71d12ee into NixOS:master Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leenaars @ymarkus @alyssais