Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nix
base: 8a2ce0f455da
Choose a base ref
...
head repository: NixOS/nix
compare: c51ee5c0336a
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Jan 5, 2021

  1. Fix conversion from JSON to fetch attributes 

    It appears as through the fetch attribute, which
is simply a variant with 3 elements, implicitly
converts boolean arguments to integers. One must
use Explicit<bool> to correctly populate it with
a boolean. This was missing from the implementation,
and resulted in clearly boolean JSON fields being
treated as numbers.
    @DanilaFe
    DanilaFe committed Jan 5, 2021
    Copy the full SHA
    988dd0a View commit details
    Browse the repository at this point in the history

  2. Merge pull request #4424 from DanilaFe/fix-attr-from-json 

    Fix conversion from JSON to fetch attributes
    @edolstra
    edolstra committed Jan 5, 2021
    Copy the full SHA
    c51ee5c View commit details
    Browse the repository at this point in the history