Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag master after branch with new unstable branch name #7

Merged
merged 1 commit into from Jan 9, 2021

Conversation

jonringer
Copy link
Contributor

To avoid having really old metadata

[16:07:17] jon@jon-desktop /home/jon/projects/nixpkgs (staging)
$ git describe
18.09-beta-110115-gb20838eb4a0

cc @worldofpeace

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/git-describe-like-attributes-for-flakes/10805/10

@cole-h
Copy link
Member

cole-h commented Jan 5, 2021

May or may not be related: NixOS/nixpkgs#83024.

EDIT: Also probably need to push tags. I don't know if git push does this by default.

To avoid having really old metadata

```
[16:07:17] jon@jon-desktop /home/jon/projects/nixpkgs (staging)
$ git describe
18.09-beta-110115-gb20838eb4a0
```
@jonringer
Copy link
Contributor Author

@cole-h yes, you are correct, i would need to push, or else the tag would only exist locally. Updated the steps

Also move the tag after the creation of the next release notes stub, so that the file exists in the tag

@jonringer
Copy link
Contributor Author

May or may not be related: NixOS/nixpkgs#83024.

It is related. Thanks :)

@jonringer jonringer merged commit bfccc1b into master Jan 9, 2021
@jonringer jonringer deleted the jonringer-tag-master branch January 9, 2021 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants