Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mdbook: 0.4.4 -> 0.4.5 #108483

Merged
merged 1 commit into from Jan 7, 2021
Merged

mdbook: 0.4.4 -> 0.4.5 #108483

merged 1 commit into from Jan 7, 2021

Conversation

andresilva
Copy link
Member

Motivation for this change

Not sure what the process is for security issues, but version 0.4.4 was affected by a security vulnerability.
The CVE for the vulnerability is CVE-2020-26297.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@andresilva
Copy link
Member Author

/marvin opt-in
/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the marvin label Jan 5, 2021
@marvin-mk2
Copy link

marvin-mk2 bot commented Jan 5, 2021

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@andresilva
Copy link
Member Author

Result of nixpkgs-review pr 108483 run on x86_64-linux 1

8 packages built:
  • disnix
  • disnixos
  • dydisnix
  • hydra-unstable
  • mdbook
  • nix-review (nixpkgs-review)
  • nix-update
  • nixFlakes (nixUnstable)

@ymarkus
Copy link
Contributor

ymarkus commented Jan 5, 2021 •
edited

I'll check in a moment, but I'm not sure if this warrants the label 1.severity: security?
Also, I can't find the maintainer on GitHub, maybe he deleted his account? Disregard this, I had a typo.

pinging @Havvy

ymarkus
ymarkus approved these changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@ymarkus ymarkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested all depending packages, but the package itself builds and works fine.

Reviewed points
  • package name fits guidelines
  • package version fits guidelines
  • package build on x86_64-linux
  • executables tested on x86_64-linux

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 108483 run on x86_64-linux 1

8 packages built:
  • disnix
  • disnixos
  • dydisnix
  • hydra-unstable
  • mdbook
  • nix-update
  • nixFlakes (nixUnstable)
  • nixpkgs-review

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108483 run on x86_64-darwin 1

6 packages failed to build and are new build failures:
1 package built:
  • mdbook

@SuperSandro2000 SuperSandro2000 merged commit fcc81bc into NixOS:master Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymarkus ymarkus ymarkus approved these changes

Assignees
No one assigned
Labels
1.severity: security 8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andresilva @ymarkus @SuperSandro2000