-
-
Notifications
You must be signed in to change notification settings - Fork 29
Support for IDEA 2020.3 #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@pSub should we add @JojOatXGME as a contributor to the repo? |
Pinging me should be fine otherwise. |
Should we make a release for this? |
Since IDEA 2020.3 is already released, I think creating a release for the plugin would be good. Thanks. |
@Mic92: I am in favor of granting @JojOatXGME write access to this repository. The contributions speak for themselves. |
@domenkozar could you invite @JojOatXGME to the NixOS organisation and nix-idea team? |
Thanks for your trust. If you grant me write access, I would like to know if there are any policies I should know about. For example any review policy. Am I free to make changes I deem appropriate for this project or should I still find at least one reviewer for my changes? |
Given the low amount of members in the project right now, requiring another reviewer is not required unless you are unsure about the change of course. |
In case @domenkozar misses this message, let me know. Than I will contact him over a different channel. |
Added. |
Resolves #21. I removed support for IDEA version 2019.3 in accordance with JetBrains' recommendation to support the latest three major versions. According to JetBrains' recent webinar, this should include about 90% to 95% of the user base.
I checked binary compatibility with IDEA version 2020.3 by using the IntelliJ Plugin Verifier. It did not find any incompatibility. However, I replaced all usages of deprecated APIs which has been found by the tool.
I also removed some unused fields in commit 3f32ecb. I'm wondering if they had any purpose in the past.