Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for IDEA 2020.3 #22

Merged
merged 9 commits into from Jan 5, 2021
Merged

Support for IDEA 2020.3 #22

merged 9 commits into from Jan 5, 2021

Conversation

JojOatXGME
Copy link
Contributor

Resolves #21. I removed support for IDEA version 2019.3 in accordance with JetBrains' recommendation to support the latest three major versions. According to JetBrains' recent webinar, this should include about 90% to 95% of the user base.

I checked binary compatibility with IDEA version 2020.3 by using the IntelliJ Plugin Verifier. It did not find any incompatibility. However, I replaced all usages of deprecated APIs which has been found by the tool.

I also removed some unused fields in commit 3f32ecb. I'm wondering if they had any purpose in the past.

@JojOatXGME
Copy link
Contributor Author

JojOatXGME commented Jan 4, 2021

@Mic92 or @pSub, can one of you review the changes? If I want to make further contributes, should I continue to mention you or is there a more favored way? I'm also limited in time, but I'm currently considering making a few more contributes. Thanks.

@Mic92
Copy link
Member

Mic92 commented Jan 5, 2021

@pSub should we add @JojOatXGME as a contributor to the repo?

@Mic92
Copy link
Member

Mic92 commented Jan 5, 2021

Pinging me should be fine otherwise.

@Mic92 Mic92 merged commit d332de0 into NixOS:master Jan 5, 2021
@Mic92
Copy link
Member

Mic92 commented Jan 5, 2021

Should we make a release for this?

@JojOatXGME
Copy link
Contributor Author

JojOatXGME commented Jan 5, 2021

Since IDEA 2020.3 is already released, I think creating a release for the plugin would be good. Thanks.

@JojOatXGME JojOatXGME deleted the idea203 branch January 5, 2021 15:53
@Mic92
Copy link
Member

Mic92 commented Jan 6, 2021

There you go: https://github.com/NixOS/nix-idea/releases/tag/v0.3.0.4 https://plugins.jetbrains.com/plugin/8607-nixidea

@pSub
Copy link
Member

pSub commented Jan 6, 2021

@Mic92: I am in favor of granting @JojOatXGME write access to this repository. The contributions speak for themselves.
@JojOatXGME: If you want write access to this repository I'll grant it to you.

@Mic92
Copy link
Member

Mic92 commented Jan 7, 2021

@domenkozar could you invite @JojOatXGME to the NixOS organisation and nix-idea team?

@JojOatXGME
Copy link
Contributor Author

Thanks for your trust. If you grant me write access, I would like to know if there are any policies I should know about. For example any review policy. Am I free to make changes I deem appropriate for this project or should I still find at least one reviewer for my changes?

@Mic92
Copy link
Member

Mic92 commented Jan 8, 2021

Thanks for your trust. If you grant me write access, I would like to know if there are any policies I should know about. For example any review policy. Am I free to make changes I deem appropriate for this project or should I still find at least one reviewer for my changes?

Given the low amount of members in the project right now, requiring another reviewer is not required unless you are unsure about the change of course.

@Mic92
Copy link
Member

Mic92 commented Jan 8, 2021

Thanks for your trust. If you grant me write access, I would like to know if there are any policies I should know about. For example any review policy. Am I free to make changes I deem appropriate for this project or should I still find at least one reviewer for my changes?

In case @domenkozar misses this message, let me know. Than I will contact him over a different channel.

@domenkozar
Copy link
Member

Added.

JojOatXGME added a commit to JojOatXGME/nix-idea that referenced this pull request Mar 8, 2024
JojOatXGME added a commit to JojOatXGME/nix-idea that referenced this pull request Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update for 2020.3
4 participants