Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnomeExtensions.material-shell: 10 -> 12 #108485

Merged
merged 1 commit into from Jan 6, 2021
Merged

gnomeExtensions.material-shell: 10 -> 12 #108485

merged 1 commit into from Jan 6, 2021

Conversation

dbirks
Copy link
Member

@dbirks dbirks commented Jan 5, 2021

Motivation for this change

Version 12 released 馃帀
https://github.com/material-shell/material-shell/releases/tag/12

I built it locally, and can confirm that the new window resizing feature works.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Jan 5, 2021
@ofborg ofborg bot requested a review from benley January 5, 2021 15:29
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108485 run on x86_64-linux 1

1 package built:
  • gnomeExtensions.material-shell

@SuperSandro2000 SuperSandro2000 merged commit 57135a3 into NixOS:master Jan 6, 2021
@dbirks dbirks deleted the material-shell-12 branch January 6, 2021 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benley benley Awaiting requested review from benley

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dbirks @SuperSandro2000