Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ghostwriter: 1.0.1 -> 2.0.0-rc3, build with newest libsForQt5 #108474

Merged
merged 1 commit into from Jan 7, 2021
Merged

ghostwriter: 1.0.1 -> 2.0.0-rc3, build with newest libsForQt5 #108474

merged 1 commit into from Jan 7, 2021

Conversation

erictapen
Copy link
Member

Motivation for this change

ghostwriter currently fails to build on nixos-unstable, also address #104474.

Things done

Bumped to latest release candidate.

@dotlambda what do you think, should we update to 2.0.0-rc3? Alternatiely I could convert this PR to draft and wait until 2.0.0 gets released.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@erictapen erictapen mentioned this pull request Jan 5, 2021
Closed
10 tasks
@ofborg ofborg bot requested a review from dotlambda January 5, 2021 12:44
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108474 run on x86_64-linux 1

1 package built:
  • ghostwriter

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 7, 2021 •
edited

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108474 run on x86_64-darwin 1

1 package failed to build and are new build failure: 
  build flags: -j4 -l4 SHELL=/nix/store/4n2ah3plbfnfz14wrzmz1pkfw78y9kz4-bash-4.4-p23/bin/bash
  /nix/store/wb2m935kldwcn1nwqc3j1n1k5ncqbq71-qttools-5.12.9-dev/bin/lrelease -silent translations/ghostwriter_ar.ts -qm build/release/translations/ghostwriter_ar.qm
  /nix/store/wb2m935kldwcn1nwqc3j1n1k5ncqbq71-qttools-5.12.9-dev/bin/lrelease -silent translations/ghostwriter_ca.ts -qm build/release/translations/ghostwriter_ca.qm
  /nix/store/wb2m935kldwcn1nwqc3j1n1k5ncqbq71-qttools-5.12.9-dev/bin/lrelease -silent translations/ghostwriter_cs.ts -qm build/release/translations/ghostwriter_cs.qm
  /nix/store/wb2m935kldwcn1nwqc3j1n1k5ncqbq71-qttools-5.12.9-dev/bin/lrelease -silent translations/ghostwriter_de.ts -qm build/release/translations/ghostwriter_de.qm
  make: *** [Makefile:921: build/release/translations/ghostwriter_de.qm] Segmentation fault: 11
  make: *** Waiting for unfinished jobs....
  make: *** [Makefile:915: build/release/translations/ghostwriter_ca.qm] Segmentation fault: 11
  make: *** [Makefile:918: build/release/translations/ghostwriter_cs.qm] Segmentation fault: 11
  make: *** [Makefile:912: build/release/translations/ghostwriter_ar.qm] Segmentation fault: 1

Please mark it as broken on darwin or set the platforms to linux only if upstream does not support darwin.

@erictapen
ghostwriter: 1.0.1 -> 2.0.0-rc3, build with newest libsForQt5
5d815cc 
- mark as broken on darwin
- add myself as maintainer
@erictapen
Copy link
Member Author

Upstream seems to support it, at least there are issues about macOS. Marked as broken on darwin. @SuperSandro2000

@SuperSandro2000 SuperSandro2000 merged commit 7a5c1d3 into NixOS:master Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda Awaiting requested review from dotlambda

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@erictapen @SuperSandro2000 @ymarkus