Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.scipy: 1.5.4 -> 1.6.0 #108455

Merged
merged 1 commit into from Jan 7, 2021
Merged

python3Packages.scipy: 1.5.4 -> 1.6.0 #108455

merged 1 commit into from Jan 7, 2021

Conversation

rmcgibbo
Copy link
Contributor

@rmcgibbo rmcgibbo commented Jan 5, 2021

Motivation for this change

https://docs.scipy.org/doc/scipy/reference/release.1.6.0.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • X ] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

prusnak
prusnak approved these changes Jan 5, 2021
View reviewed changes
Copy link
Member

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

untested, code looks ok

@SuperSandro2000
Copy link
Member

/rebase-staging

@github-actions github-actions bot changed the base branch from master to staging January 5, 2021 12:13
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 7, 2021 •
edited

Going to build the commit against master and if this succeeds building scipy we can merge it into staging.

Edit: well that won't work so we just go geronimo.

@SuperSandro2000 SuperSandro2000 merged commit cd8b8f8 into NixOS:staging Jan 7, 2021
@rmcgibbo rmcgibbo deleted the scipy branch January 7, 2021 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rmcgibbo @SuperSandro2000 @prusnak