Skip to content

python3Packages.pygal: unbreak with latest pytest #108488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2021
Merged

python3Packages.pygal: unbreak with latest pytest #108488

merged 1 commit into from
Jan 5, 2021
+10 −1

Conversation

rmcgibbo
Copy link
Contributor

@rmcgibbo rmcgibbo commented Jan 5, 2021 •
edited
Loading

Motivation for this change

Fix failure during test collection caused by upgrading pytest with patch from upstream: https://hydra.nixos.org/build/134198968

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@rmcgibbo
Copy link
Contributor Author

rmcgibbo commented Jan 5, 2021

Result of nixpkgs-review pr 108488 run on x86_64-linux 1

3 packages built:
  • python37Packages.pygal
  • python38Packages.pygal
  • python39Packages.pygal

mweinelt
mweinelt approved these changes Jan 5, 2021
View reviewed changes
Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Do you think it's a good idea to poke them about a new release? There apparently haven't been any in a good while.

@mweinelt mweinelt merged commit 0a22509 into NixOS:master Jan 5, 2021
@rmcgibbo rmcgibbo deleted the pygal branch January 5, 2021 16:37
@rmcgibbo
Copy link
Contributor Author

rmcgibbo commented Jan 5, 2021

A dozen commits since 2018, so I doubt it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt

@FRidh FRidh

@jonringer jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rmcgibbo @mweinelt