Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0d7ccb77915b
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: e10ef1faec06
Choose a head ref
  • 3 commits
  • 2 files changed
  • 2 contributors

Commits on Jan 2, 2021

  1. opentabletdriver: misc improvements

    - Use install instead of cp when possible
    - Add missing hooks
    - Use desktopItem instead of packaging desktop file manually
    thiagokokada committed Jan 2, 2021
    Copy the full SHA
    0a14936 View commit details
  2. Verified

    This commit was signed with the committer’s verified signature. The key has expired.
    vbgl Vincent Laporte
    Copy the full SHA
    a239105 View commit details

Commits on Jan 5, 2021

  1. Merge pull request #108131 from thiagokokada/opentabletdriver-misc-im…

    …provements
    
    opentabletdriver: misc improvements to package/module
    kevincox authored Jan 5, 2021

    Verified

    This commit was signed with the committer’s verified signature. The key has expired.
    jluttine Jaakko Luttinen
    Copy the full SHA
    e10ef1f View commit details
Showing with 37 additions and 16 deletions.
  1. +12 −3 nixos/modules/hardware/opentabletdriver.nix
  2. +25 −13 pkgs/tools/X11/opentabletdriver/default.nix
15 changes: 12 additions & 3 deletions nixos/modules/hardware/opentabletdriver.nix
Original file line number Diff line number Diff line change
@@ -24,6 +24,15 @@ in
'';
};

package = mkOption {
type = types.package;
default = pkgs.opentabletdriver;
defaultText = "pkgs.opentabletdriver";
description = ''
OpenTabletDriver derivation to use.
'';
};

daemon = {
enable = mkOption {
default = true;
@@ -37,9 +46,9 @@ in
};

config = mkIf cfg.enable {
environment.systemPackages = with pkgs; [ opentabletdriver ];
environment.systemPackages = [ cfg.package ];

services.udev.packages = with pkgs; [ opentabletdriver ];
services.udev.packages = [ cfg.package ];

boot.blacklistedKernelModules = cfg.blacklistedKernelModules;

@@ -50,7 +59,7 @@ in

serviceConfig = {
Type = "simple";
ExecStart = "${opentabletdriver}/bin/otd-daemon -c ${opentabletdriver}/lib/OpenTabletDriver/Configurations";
ExecStart = "${cfg.package}/bin/otd-daemon -c ${cfg.package}/lib/OpenTabletDriver/Configurations";
Restart = "on-failure";
};
};
38 changes: 25 additions & 13 deletions pkgs/tools/X11/opentabletdriver/default.nix
Original file line number Diff line number Diff line change
@@ -2,7 +2,6 @@
, lib
, fetchFromGitHub
, fetchurl
, makeWrapper
, linkFarmFromDrvs
, dotnet-netcore
, dotnet-sdk
@@ -15,7 +14,9 @@
, libevdev
, libnotify
, udev
, copyDesktopItems
, makeDesktopItem
, makeWrapper
, wrapGAppsHook
}:

@@ -39,6 +40,7 @@ stdenv.mkDerivation rec {
dotnet-sdk
dotnetPackages.Nuget
dpkg
copyDesktopItems
makeWrapper
wrapGAppsHook
];
@@ -62,6 +64,8 @@ stdenv.mkDerivation rec {
];

configurePhase = ''
runHook preConfigure
export HOME=$(mktemp -d)
export DOTNET_CLI_TELEMETRY_OPTOUT=1
export DOTNET_SKIP_FIRST_TIME_EXPERIENCE=1
@@ -76,20 +80,25 @@ stdenv.mkDerivation rec {
for project in OpenTabletDriver.{Console,Daemon,UX.Gtk}; do
dotnet restore --source "$PWD/nixos" $project
done
runHook postConfigure
'';

buildPhase = ''
runHook preBuild
for project in OpenTabletDriver.{Console,Daemon,UX.Gtk}; do
dotnet build $project \
--no-restore \
--configuration Release \
--framework net5
done
runHook postBuild
'';

installPhase = ''
mkdir -p $out/lib/OpenTabletDriver/
cp -r ./OpenTabletDriver/Configurations/ $out/lib/OpenTabletDriver/
runHook preInstall
for project in OpenTabletDriver.{Console,Daemon,UX.Gtk}; do
dotnet publish $project \
@@ -119,25 +128,28 @@ stdenv.mkDerivation rec {
--set DOTNET_ROOT "${dotnet-netcore}" \
--suffix LD_LIBRARY_PATH : "${lib.makeLibraryPath runtimeDeps}"
mkdir -p $out/share/{applications,pixmaps}
mkdir -p $out/lib/OpenTabletDriver
cp -rv ./OpenTabletDriver/Configurations $out/lib/OpenTabletDriver
install -Dm644 $src/OpenTabletDriver.UX/Assets/otd.png -t $out/share/pixmaps
cp -r $src/OpenTabletDriver.UX/Assets/* $out/share/pixmaps
# TODO: Ideally this should be build from OpenTabletDriver/OpenTabletDriver-udev instead
dpkg-deb --fsys-tarfile ${debPkg} | tar xf - ./usr/lib/udev/rules.d/30-opentabletdriver.rules
install -Dm644 ./usr/lib/udev/rules.d/30-opentabletdriver.rules -t $out/lib/udev/rules.d
cp -r ${makeDesktopItem {
runHook postInstall
'';

desktopItems = [
(makeDesktopItem {
desktopName = "OpenTabletDriver";
name = "OpenTabletDriver";
exec = "otd-gui";
icon = "otd";
comment = meta.description;
type = "Application";
categories = "Utility;";
}}/share/applications/* $out/share/applications
# TODO: Ideally this should be build from OpenTabletDriver/OpenTabletDriver-udev instead
dpkg-deb --fsys-tarfile ${debPkg} | tar xf - ./usr/lib/udev/rules.d/30-opentabletdriver.rules
mkdir -p $out/lib/udev/rules.d
cp ./usr/lib/udev/rules.d/* $out/lib/udev/rules.d
'';
})
];

dontWrapGApps = true;
dontStrip = true;