Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ccloud-cli: Declare the actual supported platforms #108454

Merged
merged 2 commits into from Mar 19, 2021
Merged

ccloud-cli: Declare the actual supported platforms #108454

merged 2 commits into from Mar 19, 2021

Conversation

kalbasit
Copy link
Member

@kalbasit kalbasit commented Jan 5, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

TODO:

  • Test it locally on Linux
  • Test it locally on Darwin

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108454 run on x86_64-linux 1

1 package built:
  • ccloud-cli

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 108454 run on x86_64-darwin 1

1 package built:
  • ccloud-cli

@kalbasit kalbasit force-pushed the opensource/nixpkgs/update-ccloud-cli branch from 3657876 to 5e76aa4 Compare March 19, 2021 22:55
@kalbasit kalbasit changed the title ccloud-cli: 0.202.0 -> 1.21.1 ccloud-cli: Declare the actual supported platforms Mar 19, 2021
@kalbasit kalbasit marked this pull request as ready for review March 19, 2021 22:56
@kalbasit
ccloud-cli: Declare the actual supported platforms
9b05bad 
Not all Linux and Darwin platforms are supported, only their x86_64
variants are supported.
@kalbasit kalbasit force-pushed the opensource/nixpkgs/update-ccloud-cli branch from 5e76aa4 to 9b05bad Compare March 19, 2021 22:59
rguevara84
rguevara84 approved these changes Mar 19, 2021
View reviewed changes
Copy link
Contributor

@rguevara84 rguevara84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kalbasit kalbasit merged commit d192117 into NixOS:master Mar 19, 2021
@kalbasit kalbasit deleted the opensource/nixpkgs/update-ccloud-cli branch March 19, 2021 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rguevara84 rguevara84 rguevara84 approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kalbasit @SuperSandro2000 @rguevara84