Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xed: init at 12.0.1 #107273

Merged
merged 1 commit into from Dec 26, 2020
Merged

xed: init at 12.0.1 #107273

merged 1 commit into from Dec 26, 2020

Conversation

arcz
Copy link
Member

@arcz arcz commented Dec 20, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 reviewed Dec 20, 2020
View reviewed changes
pkgs/development/libraries/xed/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/xed/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/xed/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107273 run on x86_64-darwin 1

1 package built:
  • xed

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107273 run on x86_64-linux 1

1 package built:
  • xed

@arcz arcz requested a review from jonringer December 21, 2020 17:58
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107273 run on x86_64-darwin 1

1 package built:
  • xed

@arcz arcz requested a review from jonringer December 24, 2020 21:58
SuperSandro2000
SuperSandro2000 reviewed Dec 25, 2020
View reviewed changes
pkgs/development/libraries/xed/default.nix Outdated
Comment on lines 31 to 34
# this will build, test and install
patchShebangs mfile.py
./mfile.py test --prefix $out
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# this will build, test and install
patchShebangs mfile.py
./mfile.py test --prefix $out
patchShebangs mfile.py
# this will build, test and install
./mfile.py test --prefix $out

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107273 run on x86_64-darwin 1

1 package built:
  • xed

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107273 run on x86_64-linux 1

1 package built:
  • xed

@SuperSandro2000 SuperSandro2000 merged commit 92ba35f into NixOS:master Dec 26, 2020
@arcz arcz deleted the xed branch December 28, 2020 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer Awaiting requested review from jonringer

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arcz @SuperSandro2000 @jonringer