Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.gitit: jailbreak #107274

Merged
merged 1 commit into from Dec 21, 2020
Merged

haskellPackages.gitit: jailbreak #107274

merged 1 commit into from Dec 21, 2020

Conversation

sternenseemann
Copy link
Member

Motivation for this change

Should fix the build failure described in #107209 for master/unstable.

The bug however is about NixOS 20.09, so my question is: Is it possible to backport haskell-updates fixes to stable? If yes how?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cdepillabout
cdepillabout requested changes Dec 21, 2020
View reviewed changes
Copy link
Member

@cdepillabout cdepillabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to backport haskell-updates fixes to stable? If yes how?

Sort of. When backporting changes, you'll also have to directly edit the hackage-packages.nix file, since it is not automatically regenerated on the release branches.

Feel free to also open a PR for that. You don't necessarily have to wait for this PR to get merged.

pkgs/development/haskell-modules/configuration-common.nix Outdated Show resolved Hide resolved
@sternenseemann sternenseemann mentioned this pull request Dec 21, 2020
Merged
10 tasks
@sternenseemann
haskellPackages.gitit: jailbreak
aeec13b 
Should fix the build failure described in NixOS#107209 for master/unstable.
@cdepillabout
Copy link
Member

Looks good, compiles for me. Thanks!

@cdepillabout cdepillabout merged commit 2ffd60c into NixOS:haskell-updates Dec 21, 2020
@sternenseemann sternenseemann deleted the haskell-updates branch December 21, 2020 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout cdepillabout requested changes

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sternenseemann @cdepillabout