Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

duf: Add darwin supoort #107271

Merged
1 commit merged into from Dec 20, 2020
Merged

duf: Add darwin supoort #107271

1 commit merged into from Dec 20, 2020

Conversation

Azd325
Copy link
Member

@Azd325 Azd325 commented Dec 20, 2020 •
edited

Motivation for this change

error: Package is not supported on ‘x86_64-darwin’, refusing to evaluate.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 8.has: package (new) labels Dec 20, 2020
@ofborg ofborg bot requested review from kalbasit and a user December 20, 2020 17:58
@ghost
Copy link

ghost commented Dec 20, 2020 •
edited by ghost

Thanks! Since (according to the README) it also supports BSDs, can you just set it to platforms.unix?
Also have you tested that it builds and works properly on a darwin machine?

@Azd325

This comment has been minimized.

Sign in to view
@Azd325
Copy link
Member Author

Azd325 commented Dec 20, 2020

Result of nixpkgs-review pr 107271 run on x86_64-darwin 1

1 package built:
  • duf

@Azd325
Copy link
Member Author

Azd325 commented Dec 20, 2020

Thanks! Since (according to the README) it also supports BSDs, can you just set it to platforms.unix?

It seems so. I changed it to platforms.unix.

Also have you tested that it builds and works properly on a darwin machine?

Yes. I did. I installed first with $ export NIXPKGS_ALLOW_UNSUPPORTED_SYSTEM=1 and now I did also a build with nixpkgs-review.

@Azd325 Azd325 marked this pull request as ready for review December 20, 2020 18:30
@ghost ghost merged commit b149945 into NixOS:master Dec 20, 2020
@Azd325 Azd325 deleted the patch-1 branch December 20, 2020 18:44
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Azd325 @Janik-Haag