Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MediaElch: init at 2.8.2 #107270

Merged
merged 2 commits into from Dec 23, 2020
Merged

MediaElch: init at 2.8.2 #107270

merged 2 commits into from Dec 23, 2020

Conversation

Stunkymonkey
Copy link
Contributor

@Stunkymonkey Stunkymonkey commented Dec 20, 2020 •
edited

Motivation for this change

A paket that is missing, which I use a lot. Maybe others are missing it too.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

this is my first submission, so any guidance is wanted.

@Stunkymonkey
Copy link
Contributor Author

i think the commit hash is not correct. i will fix this shortly

gebner
gebner reviewed Dec 20, 2020
View reviewed changes
pkgs/applications/misc/mediaelch/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/mediaelch/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@Stunkymonkey
Copy link
Contributor Author

hash is now correct and i ran nixpkgs-fmt

SuperSandro2000
SuperSandro2000 reviewed Dec 20, 2020
View reviewed changes
maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/applications/misc/mediaelch/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/mediaelch/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/mediaelch/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/mediaelch/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107270 run on x86_64-linux 1

1 package built:
  • mediaelch

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107270 run on x86_64-linux 1

1 package built:
  • mediaelch

SuperSandro2000
SuperSandro2000 approved these changes Dec 22, 2020
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

@SuperSandro2000 SuperSandro2000 merged commit e7ccc64 into NixOS:master Dec 23, 2020
@Stunkymonkey Stunkymonkey deleted the mediaelch_init branch December 23, 2020 16:14
@Stunkymonkey Stunkymonkey mentioned this pull request Jan 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gebner gebner gebner left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Stunkymonkey @SuperSandro2000 @gebner