Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.hstspreload: 2020.6.9 -> 2020.11.21 #107272

Merged
merged 1 commit into from Dec 20, 2020
Merged

python3Packages.hstspreload: 2020.6.9 -> 2020.11.21 #107272

merged 1 commit into from Dec 20, 2020

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Dec 20, 2020

Motivation for this change

Updated to latest upstream release 2020.11.21

No changelog available.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from costrouc December 20, 2020 18:19
@mweinelt
Copy link
Member

Result of nixpkgs-review pr 107272 run on x86_64-linux 1

3 packages built:
  • python37Packages.hstspreload
  • python38Packages.hstspreload
  • python39Packages.hstspreload

@SuperSandro2000 SuperSandro2000 merged commit 9cb4d2f into NixOS:master Dec 20, 2020
@mweinelt
Copy link
Member

@SuperSandro2000 I was still in the process of reviewing this. Please don't be so hasty.

The package would benefit from a pythonImportsCheck, to check whether it can be imported. https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/python.section.md#using-pythonimportscheck

@mweinelt
Copy link
Member

Added in e55f772.

@fabaff fabaff deleted the hstspreload branch December 21, 2020 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fabaff @mweinelt @SuperSandro2000