Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nitrokey-app towards 1.4.2 #107289

Closed
wants to merge 2 commits into from
Closed

Conversation

andigi89
Copy link

@andigi89 andigi89 commented Dec 20, 2020

updated to the current version 1.4.2

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

updated to the current version 1.4.2
@andigi89
Copy link
Author

I have updated it to 1.4.2. - the nix-build was succesfull as well as starting the nitrokey-app on ./results/bin

Copy link
Member

@teto teto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you must change the sha256 otherwise it is still installing the older version.

@andigi89 andigi89 requested a review from teto December 20, 2020 22:36
@andigi89
Copy link
Author

andigi89 commented Dec 20, 2020

@teto Well, how can I update/change the sha256?

@teto
Copy link
Member

teto commented Dec 20, 2020

just replace one figure by another (a 3 into a 2 for instance) and try to buld it. It should error out and give you the new hash.

@andigi89
Copy link
Author

@teto - hopefully the new sha256 should work

@mweinelt
Copy link
Member

Please reconsider your commit message wrt. CONTRIBUTING.md. Also squash your commits together, it's still a single change.

https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes

Copy link
Author

@andigi89 andigi89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully done

@mweinelt
Copy link
Member

No visible change.

@KaiHa
Copy link
Contributor

KaiHa commented Jan 3, 2021

Hello @andigi89, I have created an PR with an update of the nitrokey-app (see #108319). Thank you for making me aware that an update was overdue.

@teto
Copy link
Member

teto commented Jan 3, 2021

you could have force-pushed your branch instead of creating a new PR instead of losing comment records.

@teto teto closed this Jan 3, 2021
@teto teto changed the title Update default.nix Update nitrokey-app towards 1.4.2 Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants