New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nitrokey-app towards 1.4.2 #107289
Conversation
updated to the current version 1.4.2
I have updated it to 1.4.2. - the nix-build was succesfull as well as starting the nitrokey-app on ./results/bin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you must change the sha256 otherwise it is still installing the older version.
@teto Well, how can I update/change the sha256? |
just replace one figure by another (a 3 into a 2 for instance) and try to buld it. It should error out and give you the new hash. |
@teto - hopefully the new sha256 should work |
Please reconsider your commit message wrt. CONTRIBUTING.md. Also squash your commits together, it's still a single change. https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully done
No visible change. |
you could have force-pushed your branch instead of creating a new PR instead of losing comment records. |
updated to the current version 1.4.2
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)