Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deluge-1_x: add removal warning #107281

Closed
wants to merge 2 commits into from
Closed

deluge-1_x: add removal warning #107281

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 20, 2020 •
edited by ghost

Tracking issue: #107280

If anyone knows a better way to add an evaluation warning for a package: Suggestions are much-appreciated.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

@petabyteboy please fix the eval error.

@SuperSandro2000
Copy link
Member

I think the right place for this is aliases.nix.

@ghost
Copy link
Author

ghost commented Jan 18, 2021

I think the right place for this is aliases.nix.

I couldn't figure out how to add a warning via aliases.nix without creating an ofborg eval error

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 19, 2021 •
edited

aliases.nix does not seem to support this. @jonringer can you help here? Or maybe @Mic92?

@jonringer
Copy link
Contributor

I don't think you can, unfortunately. :(

Update pkgs/top-level/aliases.nix
f4acaa7 
Co-authored-by: Jonathan Ringer <jonringer@users.noreply.github.com>
@ghost ghost closed this Apr 29, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SuperSandro2000 @jonringer @Mic92