Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nix
base: fdc8e7cbe772
Choose a base ref
...
head repository: NixOS/nix
compare: ae3c3e3bb29c
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Dec 16, 2020

  1. Better detect when buildPaths would be a no-op 

    `buildPaths` can be called even for stores where it's not defined in case it's
bound to be a no-op.
The “no-op detection” mechanism was only detecting the case wher `buildPaths`
was called on a set of (non-drv) paths that were already present on the store.

This commit extends this mechanism to also detect the case where `buildPaths`
is called on a set of derivation outputs which are already built on the store.

This only works with the ca-derivations flag. It could be possible to
extend this to also work without it, but it would add quite a bit of
complexity, and it's not used without it anyways.
    @thufschmitt
    thufschmitt committed Dec 16, 2020
    Copy the full SHA
    6e89927 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #4370 from NixOS/ca/more-precise-build-noop 

    Better detect when `buildPaths` would be a no-op
    @edolstra
    edolstra committed Dec 16, 2020
    Copy the full SHA
    ae3c3e3 View commit details
    Browse the repository at this point in the history