Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vimPlugins.vim-DetectSpellLang: init at 2020-01-13 #107026

Merged
merged 1 commit into from Jan 3, 2021
Merged

vimPlugins.vim-DetectSpellLang: init at 2020-01-13 #107026

merged 1 commit into from Jan 3, 2021

Conversation

GovanifY
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: vim label Dec 16, 2020
@symphorien
Copy link
Member

I wonder if we should patch the plugin here to depend on aspell https://github.com/Konfekt/vim-DetectSpellLang/blob/master/plugin/detectspelllang.vim#L16

@GovanifY
Copy link
Member Author

@symphorien This should now take care of that.

@GovanifY GovanifY force-pushed the autospellcheck branch 2 times, most recently from 390db76 to 7a5394d Compare December 17, 2020 03:59
@GovanifY
Copy link
Member Author

@symphorien Can you please review again this PR?

@symphorien
Copy link
Member

Hmm actually the patch was a bad idea it generates an error:

Erreur détectée en traitant function detectspelllang#detectspelllang :
ligne   23 :
E15: Expression invalide : g:detectspelllang_langs./nix/store/l9rzczak0chmxc92p6fwg243ks6p3024-aspell-0.60.8/bin/aspell

because of https://github.com/Konfekt/vim-DetectSpellLang/blob/master/autoload/detectspelllang.vim#L24

so g:detectspelllang_program should stay "aspell".

Let's not patch the plugin at all and sorry for the wrong review.

@GovanifY
Copy link
Member Author

GovanifY commented Jan 3, 2021

@symphorien removed the patch, should be good now!

@symphorien symphorien merged commit 934a674 into NixOS:master Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: vim 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GovanifY @symphorien