Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lxqt: update to version 0.16.0 #107027

Merged
merged 30 commits into from Dec 22, 2020
Merged

lxqt: update to version 0.16.0 #107027

merged 30 commits into from Dec 22, 2020

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Dec 16, 2020

Motivation for this change

Update LXQt to version 0.16.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff and commit log looks great. If you tested it and it's functional then it should be good to go IMO.

@romildo
Copy link
Contributor Author

romildo commented Dec 16, 2020

I have tested it on a virtual machine and it looks good.

Except for issue #70780, which prevents correctly applying themes to the panel. This is an old issue which exists since LXQt was changed to use qt5's mkDerivation.

@romildo romildo merged commit a1c0047 into NixOS:master Dec 22, 2020
@romildo romildo deleted the upd.lxqt branch December 22, 2020 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants