Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nix-index: Wrap an unwrapped derivation #106959

Closed
wants to merge 1 commit into from
Closed

nix-index: Wrap an unwrapped derivation #106959

wants to merge 1 commit into from

Conversation

doronbehar
Copy link
Contributor

Essentially allow overriding the nix package used in the wrapping,
without rebuilding the rust package.

Motivation for this change

Fix #106515 - cc @poscat0x04 .

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from bennofs December 15, 2020 11:25
@matthewbauer
Copy link
Member

The main concern with wrapping in this way is that it makes it much harder to override the Rust "unwrapped" derivation.

Would it be more helpful to use "--suffix" instead of "--prefix" so the user can use their own Nix version?

@doronbehar
nix-index: Wrap an unwrapped derivation
4a87b31 
Essentially allow overriding the `nix` package used in the wrapping,
without rebuilding the rust package.
@doronbehar
Copy link
Contributor Author

Would it be more helpful to use "--suffix" instead of "--prefix" so the user can use their own Nix version?

I think it depends on what the maintainer meant when they wrapped it. If it was meant to ensure compatibility, it would defeat the purpose to use --suffix, because a user might have a nix in their path (which would then be used instead of what in the suffix of the PATH in the wrapper) which might not be compatible.

The main concern with wrapping in this way is that it makes it much harder to override the Rust "unwrapped" derivation.

I modified the changes so now it is possible to override the unwrapped derivation as well, with examples in the comments of wrapper.nix.

@doronbehar doronbehar marked this pull request as draft December 19, 2020 17:58
wmertens
wmertens approved these changes Dec 30, 2020
View reviewed changes
Copy link
Contributor

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuperSandro2000
Copy link
Member

Does the nix version used by nix-index even matter?

@poscat0x04
Copy link
Contributor

It probably does not, as nix-index only relies on nix-env. A better option might be to remove the wrapper altogether.

@stale
Copy link

stale bot commented Jul 20, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 20, 2021
@doronbehar doronbehar closed this Dec 23, 2021
@doronbehar doronbehar deleted the pkg/nix-index branch March 2, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmertens wmertens wmertens approved these changes

@bennofs bennofs Awaiting requested review from bennofs

Assignees
No one assigned
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 9.needs: community feedback 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Separate nix-index into wrapped and unwrapped versions
5 participants
@doronbehar @matthewbauer @SuperSandro2000 @poscat0x04 @wmertens